Re: [Qemu-devel] [PATCH] qapi-schema: mark InetSocketAddress as mandatory again

[Markus Armbruster]

"Daniel P. Berrange" <address@hidden> writes:

> Revert the qapi-schema.json change done in:
>
>   commit 0983f5e6af76d5df8c6346cbdfff9d8305fb6da0
>   Author: Daniel P. Berrange <address@hidden>
>   Date:   Tue Sep 1 14:46:50 2015 +0100
>
>     sockets: allow port to be NULL when listening on IP address
>
> Switching "port" from mandatory to optional causes the QAPI
> code generator to add a 'has_port' field to the InetSocketAddress
> struct. No code that created InetSocketAddress objects was updated
> to set 'has_port = true', which caused the non-NULL port strings
> to be silently dropped when copying InetSocketAddress objects.
>
> Reported-by: Knut Omang <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>

I'll take this through my tree before even more people get bitten.