[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] trace: fix make foo-timestamp rules
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] trace: fix make foo-timestamp rules |
|
Date: |
Thu, 29 Oct 2015 16:20:17 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Stefan Hajnoczi writes:
> The Makefile uses intermediate timestamp files to avoid rebuilding if
> tracetool output is unchanged.
> Timestamps are implemented incorrectly. This was fixed for rules.mak in
> commit 4b25966ab976f3a7fd9008193b2defcc82f8f04d ("rules.mak: cleanup
> config generation rules") but never fixed in trace/Makefile.objs.
> The problem with the old timestamp implementation was that make doesn't
> notice the updated file modification time until the next time it is run.
> It was necessary to run make twice in a row to achieve a full rebuild.
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Fixes broken code and it's cleaner. Thanks!
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth