Re: [Qemu-devel] [PATCH v2 16/16] vl.c: Reword fw_cfg name prefix warning

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> Make it a shorter and simpler phrase.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  vl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 6b831eb..67f75da 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2276,8 +2276,8 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, 
> Error **errp)
>          return -1;
>      }
>      if (strncmp(name, "opt/", 4) != 0) {
> -        error_report("warning: externally provided fw_cfg item names "
> -                     "should be prefixed with \"opt/\"!");
> +        error_report("warning: no \"opt/\" prefix on fw_cfg item name '%s'",
> +                     name);
>      }
>      if (nonempty_str(str)) {
>          size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */

The loss of the '!' is an improvement.  The rest perhaps not so much.