Re: [Qemu-devel] [PATCH v4 for 2.5 0/3] qga: non-blocking fd cleanups

[Michael Roth]

Quoting Denis V. Lunev (2015-10-28 10:13:54)
> This patchset is reincarnation of one patch discussed in the scope of
> QEMU 2.4 and rejected for that time. Actually we should use
> non-blocking descriptors in QGA on Windows in guest-file-open exactly
> like was done for Posix.
> 
> Changes from v3:
> - handle_set_nonblocking now is local function in qga/commands-win32.c
>   It works only in one way - set handle nonblocking.
> 
> Changes from v2:
> - added fix for wrong argument to CloseHandle
> - switched setting non-block for pipes to use separate function
> 
> Changes from v1:
> - call to qemu_fd_register is moved to a proper place
> - moved declaration of opt to a proper place
> 
> Signed-off-by: Denis V. Lunev <address@hidden>
> Signed-off-by: Olga Krishtal <address@hidden>
> CC: Yuri Pudgorodskiy <address@hidden>
> CC: Michael Roth <address@hidden>
> 
> Denis V. Lunev (1):
>   qga: drop hand-made guest_file_toggle_flags helper
> 
> Olga Krishtal (2):
>   qga: fixed CloseHandle in qmp_guest_file_open
>   qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

Thanks, applied to qga tree:

  https://github.com/mdroth/qemu/commits/qga

> 
>  qga/commands-posix.c | 27 ++-------------------------
>  qga/commands-win32.c | 29 ++++++++++++++++++++++++++++-
>  2 files changed, 30 insertions(+), 26 deletions(-)
> 
> -- 
> 2.1.4
>