[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] trace: add make dependencies on tracetool s
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] trace: add make dependencies on tracetool source |
|
Date: |
Fri, 30 Oct 2015 09:46:53 +0000 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Oct 29, 2015 at 04:28:49PM +0100, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> > ######################################################################
> > +# tracetool source files
> > +# Every rule that invokes tracetool must depend on this so code is
> > regenerated
> > +# if tracetool itself changes.
> > +
> > +tracetool-y = $(SRC_PATH)/scripts/tracetool.py
> > +tracetool-y += $(SRC_PATH)/scripts/tracetool/*.py
> > +tracetool-y += $(SRC_PATH)/scripts/tracetool/backend/*.py
> > +tracetool-y += $(SRC_PATH)/scripts/tracetool/format/*.py
>
> If 'find' is an acceptable build dependency, I'd rather use this to avoid
> missing future sub-directories:
>
> tracetool-y = $(SRC_PATH)/scripts/tracetool.py
> tracetool-y += $(shell find $(SRC_PATH)/scripts/tracetool -path "*.py")
find is already used in Makefile so it should be safe. Thanks!
signature.asc
Description: PGP signature