qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 04/54] Move configuration section writing


From: Dr. David Alan Gilbert
Subject: Re: [Qemu-devel] [PATCH v8 04/54] Move configuration section writing
Date: Fri, 30 Oct 2015 12:47:05 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

* Amit Shah (address@hidden) wrote:
> On (Tue) 29 Sep 2015 [09:37:28], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > The vmstate_configuration is currently written
> > in 'qemu_savevm_state_begin', move it to
> > 'qemu_savevm_state_header' since it's got a hard
> > requirement that it must be the 1st thing after
> > the header.
> > (In postcopy some 'command' sections get sent
> > early before the saving of the main sections
> > and hence before qemu_savevm_state_begin).
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> 
> Reviewed-by: Amit Shah <address@hidden>
> 
> The function name 'savevm_state_header()' isn't accurate anymore.  Not
> serious for this series.

Well, it does still write the header; but if you have a simple
better name, I'd be happy to change it.

Dave

> 
>               Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK



reply via email to

[Prev in Thread] Current Thread [Next in Thread]