[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio dev
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices |
Date: |
Fri, 30 Oct 2015 13:20:48 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote:
[...]
> index 095de5d..0a08531 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -2,7 +2,51 @@
> #define HW_COMPAT_H
>
> #define HW_COMPAT_2_4 \
> - /* empty */
> + {\
> + .driver = "virtio-blk-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
Why not a single virtio-pci.disable-pcie=on entry, instead of one entry
for each subclass?
> + },{\
> + .driver = "virtio-scsi-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-net-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-input-host-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-keyboard-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-mouse-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-serial-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-tablet-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-gpu-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-balloon-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-rng-pci",\
> + .property = "disable-pcie",\
> + .value = "on",\
> + },
>
> #define HW_COMPAT_2_3 \
> {\
> --
> 2.1.0
>
--
Eduardo