[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/25] QAPI patches
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 00/25] QAPI patches |
Date: |
Fri, 30 Oct 2015 14:03:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/30/2015 01:47 PM, Peter Maydell wrote:
> On 30 October 2015 at 15:42, Markus Armbruster <address@hidden> wrote:
>> char: Convert to new qapi union layout
> Hi; I'm afraid this doesn't build on w32:
>
> /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function
> ‘qmp_chardev_open_file’:
> /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4051: error:
> ‘ChardevBackend’ has no member named ‘file’
> /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function
> ‘qmp_chardev_open_serial’:
> /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4073: error:
> ‘ChardevBackend’ has no member named ‘serial’
I'm not set up for easily cross-compiling qemu to windows at the moment,
which is why I missed it. But the fix is easy (sent separately).
Hopefully that's the only #ifdef spot of code I missed, and we aren't
going to play the "whack-a-mole" game of seeing what fails to compile on
the next platform after my w32 fixup is squashed in.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 17/25] net: Convert to new qapi union layout, (continued)
- [Qemu-devel] [PULL 17/25] net: Convert to new qapi union layout, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 15/25] block: Convert to new qapi union layout, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 22/25] qapi: Finish converting to new qapi union layout, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 14/25] tests: Convert to new qapi union layout, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 11/25] qapi-visit: Remove redundant functions for flat union base, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 19/25] input: Convert to new qapi union layout, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 18/25] char: Convert to new qapi union layout, Markus Armbruster, 2015/10/30
- [Qemu-devel] [PULL 23/25] qapi: Reserve 'u' member name, Markus Armbruster, 2015/10/30
- Re: [Qemu-devel] [PULL 00/25] QAPI patches, Peter Maydell, 2015/10/30
- Re: [Qemu-devel] [PULL 00/25] QAPI patches,
Eric Blake <=