Re: [Qemu-devel] [PULL 00/25] QAPI patches

[Peter Maydell]

On 30 October 2015 at 20:03, Eric Blake <address@hidden> wrote:
> On 10/30/2015 01:47 PM, Peter Maydell wrote:
>> On 30 October 2015 at 15:42, Markus Armbruster <address@hidden> wrote:
>
>>>       char: Convert to new qapi union layout
>
>> Hi; I'm afraid this doesn't build on w32:
>>
>> /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function
>> ‘qmp_chardev_open_file’:
>> /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4051: error:
>> ‘ChardevBackend’ has no member named ‘file’
>> /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function
>> ‘qmp_chardev_open_serial’:
>> /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4073: error:
>> ‘ChardevBackend’ has no member named ‘serial’
>
> I'm not set up for easily cross-compiling qemu to windows at the moment,
> which is why I missed it.  But the fix is easy (sent separately).
> Hopefully that's the only #ifdef spot of code I missed, and we aren't
> going to play the "whack-a-mole" game of seeing what fails to compile on
> the next platform after my w32 fixup is squashed in.

OSX and the arm32, arm64 and ppc64be hosts all built ok. My x86
box does stop after the first failed build, but the only things
after w32 are clang and the all-linux-static builds (plus the
'make check' run for everything). So no guarantees, but this
is probably the last one.

thanks
-- PMM