[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit inst
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions |
|
Date: |
Fri, 30 Oct 2015 13:54:33 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/29/2015 12:31 AM, Xiao Guangrong wrote:
> These instructions are used by NVDIMM drivers and the specification
> locates at:
> https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf
>
> There instructions are available on Skylake Server
>
> Signed-off-by: Xiao Guangrong <address@hidden>
> ---
> target-i386/cpu.c | 8 +++++---
> target-i386/cpu.h | 3 +++
> 2 files changed, 8 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
Although it would be nice to update the comments in translate.c to include the
new insns, since they overlap mfence and sfence. At present we only check for
SSE enabled when accepting these; I suppose it's easiest to consider it invalid
to specify +clwb,-sse?
r~