qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_siz


From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()
Date: Sat, 31 Oct 2015 22:06:10 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0



On 10/31/2015 05:37 PM, Vladimir Sementsov-Ogievskiy wrote:
On 31.10.2015 10:26, Xiao Guangrong wrote:


On 10/30/2015 09:26 PM, Vladimir Sementsov-Ogievskiy wrote:
logic is changed:
     in old version gethugepagesize on statfs error generates exit(1)
     in new it returns getpagesize() in this case (through fd_getpagesize)
(I think, fd_getpagesize should be fixed to handle error)

Indeed. I will let fd_getpagesize() return 0 if statfs is failed, then the 
caller
handle the error properly.

Why not use classic error codes < 0? Just change size_t to ssize_t and return 
exactly fstatfs return
value.

Yup, it's better, however, i am planning to introduce a Error parameter and 
error
condition can be checked by if Error is NULL as Eduardo suggested.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]