[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: call begin, log_start and commit when r
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory: call begin, log_start and commit when registering a new listener |
|
Date: |
Mon, 2 Nov 2015 12:30:50 +0000 |
On 2 November 2015 at 08:24, Paolo Bonzini <address@hidden> wrote:
> This ensures that cpu_reload_memory_map() is called as soon as
> tcg_cpu_address_space_init() is called, and before cpu->memory_dispatch
> is used. qemu-system-s390x never changes the address spaces after
> tcg_cpu_address_space_init() is called, and thus tcg_commit() is never
> called. This causes a SIGSEGV.
>
> Reported-by: Philipp Kern <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Fixes: 0a1c71cec63e95f9b8d0dc96d049d2daa00c5210
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
This is how I expected the memory listener API to work when I wrote
the exec.c change, anyway :-)
thanks
-- PMM