qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] io/buffer: avoid memmove at each qio_buffer


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 2/2] io/buffer: avoid memmove at each qio_buffer_advance
Date: Tue, 03 Nov 2015 12:17:18 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Peter Lieven <address@hidden> writes:

> memmove isn't exactly cheap at it involves temporary buffers
> if the memory areas are overlapping.

Really?  The memmove() I've seen detect whether to copy forward or
backward.  None of them copies through a bounce buffer.

Avoiding it can be worthwhile regardless.

>                                      So make qio_buffer_advance
> basically a pointer adjustment, but still keep the wasted memory
> in reasonable limits.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]