qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and con


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging
Date: Tue, 3 Nov 2015 18:50:52 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0


On 03/11/2015 18:42, Denis V. Lunev wrote:
> 
> There 2 small notes here:
> - there is small patch with 'all' alias for all tracepoints which
>   could also be useful in the scope of this work:
>   [PATCH v2 1/1] allow to enable all tracepoints via alias all
> 
> - it would be great if patches from my log patchset will be merged.
>   I'll port them tomorrow on top of this set (if will not work on
>   findings in locking patchset)
>   Switch from inline call to #define and QMP/QAPI logging seems
>   really necessary. timestamp could be enabled or not but it is
>   better to use unified approach for logging timestamps and
>   tracing timestamps.

I think the "right" way would be to add tracepoints to the qmp_*
functions, or to make your logging a tracepoint.  BTW, why are you not
logging QMP commands from the Virtuozzo management tool?  That's what
libvirt is doing, you can find the JSON in qemu.log IIRC.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]