Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

[Fam Zheng]

On Tue, 11/03 11:56, Peter Maydell wrote:
> On 3 November 2015 at 11:22, Stefan Hajnoczi <address@hidden> wrote:
> > On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote:
> >> On Mon, 11/02 14:06, Stefan Hajnoczi wrote:
> >> Actually the document is wrong about module support, the default is off:
> >
> > These issues are independent of this patch, but...
> >
> >> > Optional features, enabled with --enable-FEATURE and
> >> > disabled with --disable-FEATURE, default is enabled if available:
> >>
> >> Maybe we should move it out of this section instead?
> >
> > There are other foo="no" default options in this section.
> >
> > I think "default is enabled if available" really refers to foo=""
> > autodetection only.
> 
> I think what it ought to say is something like
> 
> "Optional features: these can be enabled with --enable-FEATURE
> or disabled with --disable-FEATURE. The default (unless otherwise
> specified below) is to autodetect support for the feature, and
> enable it if possible, and disable it if not."
> 
> Then options in the list which don't default to 'autodetect'
> should say so, like 'debug-tcg' does now.

Sounds good to me. For this patch:

Reviewed-by: Fam Zheng <address@hidden>