[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval |
Date: |
Wed, 4 Nov 2015 10:52:20 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/03/2015 08:43 PM, Yang Hongyang wrote:
> Some commit message would be better.
+1
>
> On 2015年11月03日 19:56, zhanghailiang wrote:
>> Signed-off-by: zhanghailiang <address@hidden>
>> Cc: Jason Wang <address@hidden>
>
> Reviewed-by: Yang Hongyang <address@hidden>
>
>> ---
>> v10: new patch
>> ---
>> net/filter-buffer.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/net/filter-buffer.c b/net/filter-buffer.c
>> index 5f0ea70..05313de 100644
>> --- a/net/filter-buffer.c
>> +++ b/net/filter-buffer.c
>> @@ -104,16 +104,6 @@ static void filter_buffer_setup(NetFilterState
>> *nf, Error **errp)
>> {
>> FilterBufferState *s = FILTER_BUFFER(nf);
>>
>> - /*
>> - * We may want to accept zero interval when VM FT solutions like MC
>> - * or COLO use this filter to release packets on demand.
>> - */
>> - if (!s->interval) {
>> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
>> - "a non-zero interval");
>> - return;
>> - }
>> -
>> s->incoming_queue =
>> qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
>> if (s->interval) {
>> timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,
>>
>
- Re: [Qemu-devel] [PATCH COLO-Frame v10 02/38] migration: Introduce capability 'x-colo' to migration, (continued)
- [Qemu-devel] [PATCH COLO-Frame v10 23/38] qmp event: Add event notification for COLO error, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 03/38] COLO: migrate colo related info to secondary node, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 30/38] COLO: Separate the process of saving/loading ram and device state, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 27/38] COLO: Process shutdown command for VM in COLO state, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 38/38] COLO: Add block replication into colo process, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 05/38] migration: Integrate COLO checkpoint process into migration, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 36/38] netfilter: Introduce an API to delete all the automatically added netfilters, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 06/38] migration: Integrate COLO checkpoint process into loadvm, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 31/38] COLO: Split qemu_savevm_state_begin out of checkpoint process, zhanghailiang, 2015/11/03