Re: [Qemu-devel] [PATCH v9 00/27] alternate layout (post-introspection cleanups, subset C)

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> No pending prerequisites; based on qemu.git master
>
> Also available as a tag at this location:
> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv9c
>
> and will soon be part of my branch with the rest of the v5 series, at:
> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
>
> v9 notes:
> More patches added, and several reorganized.  Lots of new patches
> from Markus, although not in the order originally proposed.
>
> The first 8 patches are fairly straightforward, and could probably
> be taken as-is. Patch 9 is a rewrite of v8 4/17, but in the opposite
> direction (document that no sorting is done, rather than attempting
> to sort), so it may need further fine-tuning.  Patches 12-21
> represents a fusion of Markus' and my attempts to rewrite v5 7/17
> into a more-reviewable set of patches, and caused further churn
> later in the series.

Hard freeze is next week.

PATCH 01-07+09 are simple cleanups, bug fixes tests and documentation,
which makes them obvious candidates for 2.5.

PATCH 08 is a feature, but harmless enough.  I still don't like it much,
but I said I'll take it.  Best before the hard freeze, though.

The remainder of the series doesn't feel like post hard freeze material.
What do you think?

I don't have the complete picture of your queue.  Please double-check
whether you got anything in it that affects introspection, because
changing introspection will become super awkward as soon as 2.5 is out.

> Patch 23 still uses tag_member.type == None; I ran out of time to
> work on Markus' idea of providing an instance of QAPISchemaBuiltinType
> to fill the role for 'qtype_code' without being exposed through .json
> files and without breaking the invariant of a valid member.type after
> check(), and wanted to get the rest of the series started under revew.
> So I may need a followup patch or even a v10 of the later half of
> this series after exploring that idea more.

I'll continue reviewing meanwhile.