[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring |
Date: |
Thu, 05 Nov 2015 09:49:03 +0100 |
On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote:
> + /* Add a new watch asap so as to not lose events
> */
This comment sounds like there is a race ("asap"). There isn't one,
correct ordering (adding the watch before reading the directory) is
enough to make sure you don't miss anything. You might see create
events for objects already in the tree though, are you prepared to
handle that?
cheers,
Gerd
- [Qemu-devel] [PATCH 0/3] usb-mtp events support, Bandan Das, 2015/11/03
- [Qemu-devel] [PATCH 1/3] usb-mtp: use a list for keeping track of children, Bandan Das, 2015/11/03
- [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/03
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/05
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/09
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/09
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/12
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/12
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/13
Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/05
[Qemu-devel] [PATCH 3/3] usb-mtp: add support for basic mtp events, Bandan Das, 2015/11/03