|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix |
Date: | Thu, 5 Nov 2015 10:25:03 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/11/2015 10:20, Richard Henderson wrote: > >> /* Ugly code */ >> int64_t scaled = (uint64_t)(int64_t)src << scale; > > You mean > > int64_t scaled = (int64_t)((uint64_t)src << scale); No, that also looks like a typo. I mean: - unnecessary cast to int64_t to get the sign extension while avoiding the impression of a typo - cast to uint64_t to avoid overflow - the shift is done in the uint64_t type - finally there is an implicit cast to int64_t Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |