[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DI
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region |
Date: |
Thu, 5 Nov 2015 15:29:54 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 02, 2015 at 05:13:22PM +0800, Xiao Guangrong wrote:
[...]
> static MemoryRegion *pc_dimm_get_memory_region(DIMMDevice *dimm)
> {
> - return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
> + Error *local_err = NULL;
> + MemoryRegion *mr;
> +
> + mr = host_memory_backend_get_memory(dimm->hostmem, &local_err);
> +
> + /*
> + * plug a pc-dimm device whose backend memory was not properly
> + * initialized?
> + */
> + assert(!local_err && mr);
I don't know if you are going to remove the errp parameter in the next
version, but if you want to simply abort in case an error is reported by
a function, you can use &error_abort.
--
Eduardo
- Re: [Qemu-devel] [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI, (continued)
[Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Xiao Guangrong, 2015/11/02
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Vladimir Sementsov-Ogievskiy, 2015/11/02
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Xiao Guangrong, 2015/11/02
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Vladimir Sementsov-Ogievskiy, 2015/11/02
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Xiao Guangrong, 2015/11/02
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Vladimir Sementsov-Ogievskiy, 2015/11/02
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Xiao Guangrong, 2015/11/03
- Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region, Vladimir Sementsov-Ogievskiy, 2015/11/05
Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region,
Eduardo Habkost <=
[Qemu-devel] [PATCH v7 21/35] dimm: keep the state of the whole backend memory, Xiao Guangrong, 2015/11/02
[Qemu-devel] [PATCH v7 22/35] dimm: introduce realize callback, Xiao Guangrong, 2015/11/02
[Qemu-devel] [PATCH v7 19/35] dimm: abstract dimm device from pc-dimm, Xiao Guangrong, 2015/11/02
[Qemu-devel] [PATCH v7 28/35] nvdimm acpi: save arg3 for NVDIMM device _DSM method, Xiao Guangrong, 2015/11/02
[Qemu-devel] [PATCH v7 32/35] nvdimm acpi: support Set Namespace Label Data function, Xiao Guangrong, 2015/11/02
[Qemu-devel] [PATCH v7 24/35] docs: add NVDIMM ACPI documentation, Xiao Guangrong, 2015/11/02
[Qemu-devel] [PATCH v7 27/35] nvdimm acpi: build ACPI nvdimm devices, Xiao Guangrong, 2015/11/02