[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that bloc
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that block drivers supports snapshots |
|
Date: |
Fri, 6 Nov 2015 13:53:37 +0000 |
|
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Thu, Nov 05, 2015 at 07:26:50AM +0100, Greg Kurz wrote:
> On Wed, 4 Nov 2015 20:19:32 +0300
> > + *
> > + * Returned block driver will be always locked.
> > + */
> > +
> > +bool bdrv_all_can_snapshot(BlockDriverState **first_bad_bs)
>
> Juan suggested bdrv_snapshot_is_possible() and FWIW you already emphasize
> that it involves all block drivers in the above comment.
I like the "all" in the function name. There is a set of bdrv_*_all()
functions that operate on all BlockDriverStates. What these functions
have in common is that they acquire AioContext. Other bdrv_*()
functions don't do this, so the naming helps make the semantics clear.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 03/11] snapshot: create bdrv_all_delete_snapshot helper, (continued)
- [Qemu-devel] [PATCH 03/11] snapshot: create bdrv_all_delete_snapshot helper, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 07/11] migration: reorder processing in hmp_savevm, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 05/11] snapshot: create bdrv_all_find_snapshot helper, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 08/11] migration: implement bdrv_all_find_vmstate_bs and bdrv_unlock helpers, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 09/11] migration: add missed aio_context_acquire for state writing/reading, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 06/11] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/04