[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 17/30] qapi: Simplify QAPISchemaObjectTypeMe
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 17/30] qapi: Simplify QAPISchemaObjectTypeMember.check() |
|
Date: |
Mon, 9 Nov 2015 07:44:46 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/09/2015 05:31 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> From: Markus Armbruster <address@hidden>
>>
>> QAPISchemaObjectTypeMember.check() currently does four things:
>>
>> 4. Check for collisions
>>
>> This piggyback on 3: before adding a new entry, we assert it's new.
>
> piggybacks (typo is mine)
What's more, I noticed it in v9, but in redoing v10 to go closer to your
original series, I reverted my touchup. Oh well :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*, (continued)
[Qemu-devel] [PATCH] fixup! qapi: Simplify error cleanup in test-qmp-*, Eric Blake, 2015/11/06
[Qemu-devel] [PATCH v10 06/30] qapi: Simplify non-error testing in test-qmp-*, Eric Blake, 2015/11/06
[Qemu-devel] [PATCH v10 13/30] qapi: Track simple union tag in object.local_members, Eric Blake, 2015/11/06
[Qemu-devel] [PATCH v10 17/30] qapi: Simplify QAPISchemaObjectTypeMember.check(), Eric Blake, 2015/11/06
[Qemu-devel] [PATCH v10 25/30] qapi: Hoist tag collision check to Variants.check(), Eric Blake, 2015/11/06
[Qemu-devel] [PATCH v10 21/30] qapi: Factor out QAPISchemaObjectTypeMember.check_clash(), Eric Blake, 2015/11/06
[Qemu-devel] [PATCH v10 24/30] qapi: Factor out QAPISchemaObjectType.check_clash(), Eric Blake, 2015/11/06
Re: [Qemu-devel] [PATCH v10 24/30] qapi: Factor out QAPISchemaObjectType.check_clash(), Markus Armbruster, 2015/11/09