Re: [Qemu-devel] [PATCH] log disasm insns when nochain + in_asm enabled

[Peter Maydell]

On 3 November 2015 at 12:13, Sergey Smolov <address@hidden> wrote:
> When 'nochain' and 'in_asm' debug options are enabled, QEMU
> does not print records about every executed translation block
>  (TB). For loop-containing programs it could be suitable to log
>  every executed TB. This patch includes a mapping between TBs and
>  disassembled instructions for this task to be implemented.
>
> Sergey Smolov (1):
>   log disasm insns when nochain + in_asm enabled

Hmm. I'm not entirely sure about this feature. in_asm is
supposed to print the disassembly of the target code when we
translate it (the help text says "for each compiled TB").
If I understand this patch right it just reprints the TB disassembly
on execution, so it doesn't give you any information you couldn't
get by looking backwards in the logfile for where the TB was
translated. What you'd really want for a "disassembly-of-insns
at execute time" is to only print the insns that actually get
run, ie if we have a TB and take an exception halfway through it
then don't print the second half with unexecuted insns, if we
actually don't run the TB because we too an early TB_EXIT code
path instead then don't print any insns, etc. Implementing that would
be a lot trickier, though...

Thanks for sending in the patch, though.

thanks
-- PMM