qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes
Date: Mon, 9 Nov 2015 20:57:26 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/09/2015 08:37 PM, Stefan Hajnoczi wrote:
On Sat, Nov 07, 2015 at 06:54:50PM +0300, Denis V. Lunev wrote:
with test
     while /bin/true ; do
         virsh snapshot-create rhel7
         sleep 10
         virsh snapshot-delete rhel7 --current
     done
with enabled iothreads on a running VM leads to a lot of troubles: hangs,
asserts, errors.

Anyway, I think that the construction like
     assert(aio_context_is_locked(aio_context));
should be widely used to ensure proper locking.

Changes from v5:
- dropped already merged patch 11
- fixed spelling in patch 1
- changed order of condition in loops in all patches. Thank you Stefan :)
- dropped patch 9
- aio_context is not acquired any more in bdrv_all_find_vmstate_bs by request
   of Stefan
- patch 10 is implemented in completely different way
I left comments on specific patches.  Besides that, I'm happy.
OK. that sounds good enough to me. These changes
are not a problem at all.

Should we ask Juan that this is good for him?

Den



reply via email to

[Prev in Thread] Current Thread [Next in Thread]