[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups |
Date: |
Tue, 10 Nov 2015 10:39:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 9 November 2015 at 18:52, Markus Armbruster <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>> Thanks, I had missed this useful improvement to the API.
>>> How does it work in cases like this where we don't have
>>> an Error* to fill in?
>>
>> You do what error_report_err() would do had you had an Error *err to
>> fill in:
>
>> In other words, you print the error message proper with error_report(),
>> and the additional information with error_printf().
>
> ...so in conclusion Andrew's patch is correct as it stands
> and I should just apply it? :-)
Yes. It got my R-by :)
- [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Andrew Jones, 2015/11/07
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Peter Maydell, 2015/11/07
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Markus Armbruster, 2015/11/09
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Peter Maydell, 2015/11/09
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Markus Armbruster, 2015/11/09
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Peter Maydell, 2015/11/09
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Markus Armbruster, 2015/11/09
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Peter Maydell, 2015/11/10
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Peter Maydell, 2015/11/10
- Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups, Andrew Jones, 2015/11/10