[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes |
Date: |
Tue, 10 Nov 2015 09:45:34 +0000 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Mon, Nov 09, 2015 at 08:57:26PM +0300, Denis V. Lunev wrote:
> On 11/09/2015 08:37 PM, Stefan Hajnoczi wrote:
> >On Sat, Nov 07, 2015 at 06:54:50PM +0300, Denis V. Lunev wrote:
> >>with test
> >> while /bin/true ; do
> >> virsh snapshot-create rhel7
> >> sleep 10
> >> virsh snapshot-delete rhel7 --current
> >> done
> >>with enabled iothreads on a running VM leads to a lot of troubles: hangs,
> >>asserts, errors.
> >>
> >>Anyway, I think that the construction like
> >> assert(aio_context_is_locked(aio_context));
> >>should be widely used to ensure proper locking.
> >>
> >>Changes from v5:
> >>- dropped already merged patch 11
> >>- fixed spelling in patch 1
> >>- changed order of condition in loops in all patches. Thank you Stefan :)
> >>- dropped patch 9
> >>- aio_context is not acquired any more in bdrv_all_find_vmstate_bs by
> >>request
> >> of Stefan
> >>- patch 10 is implemented in completely different way
> >I left comments on specific patches. Besides that, I'm happy.
> OK. that sounds good enough to me. These changes
> are not a problem at all.
>
> Should we ask Juan that this is good for him?
I think the requested changes won't be controversial. Sending the next
revision should be fine.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 06/10] migration: drop find_vmstate_bs check in hmp_delvm, (continued)
- [Qemu-devel] [PATCH 06/10] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 02/10] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 04/10] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 09/10] migration: implement bdrv_all_find_vmstate_bs helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 10/10] migration: normalize locking in migration/savevm.c, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm, Denis V. Lunev, 2015/11/07
- Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes, Stefan Hajnoczi, 2015/11/09