[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm
From: |
Denis V. Lunev |
Subject: |
[Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm |
Date: |
Tue, 10 Nov 2015 17:25:33 +0300 |
State deletion can be performed on running VM which reduces VM downtime
This approach looks a bit more natural.
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Juan Quintela <address@hidden>
---
migration/savevm.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index c2d677d..f4da064 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1267,6 +1267,15 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
return;
}
+ /* Delete old snapshots of the same name */
+ if (name && bdrv_all_delete_snapshot(name, &bs1, &local_err) < 0) {
+ monitor_printf(mon,
+ "Error while deleting snapshot on device '%s': %s\n",
+ bdrv_get_device_name(bs1), error_get_pretty(local_err));
+ error_free(local_err);
+ return;
+ }
+
bs = find_vmstate_bs();
if (!bs) {
monitor_printf(mon, "No block device can accept snapshots\n");
@@ -1304,15 +1313,6 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm);
}
- /* Delete old snapshots of the same name */
- if (name && bdrv_all_delete_snapshot(name, &bs1, &local_err) < 0) {
- monitor_printf(mon,
- "Error while deleting snapshot on device '%s': %s\n",
- bdrv_get_device_name(bs1), error_get_pretty(local_err));
- error_free(local_err);
- goto the_end;
- }
-
/* save the VM state */
f = qemu_fopen_bdrv(bs, 1);
if (!f) {
--
2.5.0
- [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 04/10] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm,
Denis V. Lunev <=
- [Qemu-devel] [PATCH 03/10] snapshot: create bdrv_all_delete_snapshot helper, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 01/10] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 10/10] migration: normalize locking in migration/savevm.c, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 06/10] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 02/10] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Denis V. Lunev, 2015/11/10
- [Qemu-devel] [PATCH 09/10] migration: implement bdrv_all_find_vmstate_bs helper, Denis V. Lunev, 2015/11/10
- Re: [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes, Fam Zheng, 2015/11/12
- Re: [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes, Stefan Hajnoczi, 2015/11/16