[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/3] tpm: avoid clang shifting negative signed warni
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 2/3] tpm: avoid clang shifting negative signed warning |
Date: |
Tue, 10 Nov 2015 15:57:34 +0000 |
clang 3.7.0 on x86_64 warns about the following:
hw/tpm/tpm_tis.c:1000:36: warning: shifting a negative signed value is
undefined [-Wshift-negative-value]
tis->loc[c].iface_id = TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/tpm/tpm_tis.c:144:10: note: expanded from macro
'TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3'
(~0 << 4)/* all of it is don't care */)
~~ ^
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 0806b5f..ff073d5 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -141,7 +141,7 @@
#define TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3 \
(TPM_TIS_IFACE_ID_INTERFACE_TIS1_3 | \
- (~0 << 4)/* all of it is don't care */)
+ (~0u << 4)/* all of it is don't care */)
/* if backend was a TPM 2.0: */
#define TPM_TIS_IFACE_ID_SUPPORTED_FLAGS2_0 \
--
2.5.0
- [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PATCH 2/3] tpm: avoid clang shifting negative signed warning,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 1/3] monitor: avoid clang shifting negative signed warning, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Stefan Hajnoczi, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Paolo Bonzini, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Peter Maydell, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Paolo Bonzini, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Markus Armbruster, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Steven Noonan, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Markus Armbruster, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Steven Noonan, 2015/11/10