Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

[Marc-André Lureau]

Hi

On Wed, Nov 11, 2015 at 3:26 PM, Victor Kaplansky <address@hidden> wrote:
>
> -      Sets the logging base address.
> +      Sets logging shared memory space.
> +      When slave has VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol
> +      feature, the log memory fd is provided in the ancillary data of
> +      VHOST_USER_SET_LOG_BASE message, the size and offset of shared
> +      memory area provided in the message.

I think this extra payload needs a better description, in payload
description above. Something like

 * A pair of 64-bit integers
   -------------
   | u64 | u64 |
   -------------

   u64: a 64-bit unsigned integer

"the size and offset of shared memory area provided in the message as
a pair of 64-bit integers."

-- 
Marc-André Lureau