Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()

[Fam Zheng]

On Mon, 11/09 23:39, Max Reitz wrote:
> bdrv_delete() is not very happy about deleting BlockDriverStates with
> dirty bitmaps still attached to them. In the past, we got around that
> very easily by relying on bdrv_close_all() bypassing bdrv_delete(), and
> bdrv_close() simply ignoring that condition. We should fix that by
> releasing all dirty bitmaps in bdrv_close() and drop the assertion in
> bdrv_delete().

What bitmaps are attached when bdrv_close() is called?  The ones created from
the monitor should probably be removed by the monitor, and the internal ones
like in migration and block jobs should probably be removed by stopping the
respective job.

Fam