Re: [Qemu-devel] [PATCH V3 3/6] ide: add support for IDEBufferedRequest

[Fam Zheng]

On Fri, 11/06 09:42, Peter Lieven wrote:
> +BlockAIOCB *ide_buffered_readv(IDEState *s, int64_t sector_num,
> +                               QEMUIOVector *iov, int nb_sectors,
> +                               BlockCompletionFunc *cb, void *opaque)
> +{
> +    BlockAIOCB *aioreq;
> +    IDEBufferedRequest *req;
> +    int c = 0;
> +
> +    QLIST_FOREACH(req, &s->buffered_requests, list) {
> +        c++;
> +    }
> +    if (c > MAX_BUFFERED_REQS) {
> +        return blk_abort_aio_request(s->blk, cb, opaque, -EIO);
> +    }
> +
> +    req = g_new0(IDEBufferedRequest, 1);
> +    req->original_qiov = iov;
> +    req->original_cb = cb;
> +    req->original_opaque = opaque;
> +    req->iov.iov_base = qemu_blockalign(blk_bs(s->blk), iov->size);

Where is this bounce buffer freed?

> +    req->iov.iov_len = iov->size;
> +    qemu_iovec_init_external(&req->qiov, &req->iov, 1);
> +
> +    aioreq = blk_aio_readv(s->blk, sector_num, &req->qiov, nb_sectors,
> +                           ide_buffered_readv_cb, req);
> +
> +    QLIST_INSERT_HEAD(&s->buffered_requests, req, list);
> +    return aioreq;
> +}
> +
>  static void ide_sector_read(IDEState *s);
>  
>  static void ide_sector_read_cb(void *opaque, int ret)