Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Peter Maydell (address@hidden) wrote:
>> On 12 November 2015 at 13:18, Peter Maydell <address@hidden> wrote:
>> > On 12 November 2015 at 13:08, Dr. David Alan Gilbert
>> > <address@hidden> wrote:
>> >> OK, can you try a simple migration by hand outside of the test harness;
>> >> just something simple like:
>> >>
>> >> ./bin/qemu-system-x86_64 -M pc -nographic
>> >> (qemu) migrate "exec: cat > /dev/null"
>> >>
>> >> and the same with q35 ?
>> >
>> > (qemu) migrate "exec: cat > /dev/null"
>> > migrate_get_current do init of current_migration 65307
>> > unqueue_page 65307
>> > 0   qemu-system-x86_64                  0x00000001067c01c3 qemu_mutex_lock 
>> > + 83
>> 
>> This turns out to be because migrate_init() is corrupting the
>> mutex memory when it does "memset(s, 0, sizeof(*s))". Presumably
>> Linux's initialized-mutex is all-zeroes, but OSX's is not.
>
> OK, thanks for finding that; I've just smoke tested the following
> patch and will post it properly after I test it more thoroughly in
> a couple of hours.

I did a patch that was almost identical. It is passing for me virt-test.

Later, Juan.