[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] migration_init: Fix lock initialisation/mak
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] migration_init: Fix lock initialisation/make it explicit |
|
Date: |
Thu, 12 Nov 2015 18:19:37 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Peter reported a lock error on MacOS after my a82d593b
> patch.
>
> migrate_get_current does one-time initialisation of
> a bunch of variables.
> migrate_init does reinitialisation even on a 2nd
> migrate after a cancel.
>
> The problem here was that I'd initialised the mutex
> in migrate_get_current, and the memset in migrate_init
> corrupted it.
>
> Remove the memset and replace it by explicit initialisation
> of fields that need initialising; this also turns out to be simpler
> than the old code that had to preserve some fields.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Fixes: a82d593b
Reviewed-by: Juan Quintela <address@hidden>
Applied