Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

[Bandan Das]

Eric Blake <address@hidden> writes:

> On 11/12/2015 03:55 PM, Bandan Das wrote:
>> There's no indication of any sort that i440fx doesn't support
>> "iommu=on""
>> 
>> Signed-off-by: Bandan Das <address@hidden>
>> ---
>>  hw/pci-host/piix.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>
>> @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, 
>> Error **errp)
>>  static void i440fx_realize(PCIDevice *dev, Error **errp)
>>  {
>>      dev->config[I440FX_SMRAM] = 0x02;
>> +
>> +    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
>> +        error_report("warning: i440fx doesn't support emulated iommu\n");
>
> No trailing \n with error_report().
>
> With that fixed (and perhaps maintainer can do it),

No problem, I sent out an updated version. Thanks for the review!

Bandan

> Reviewed-by: Eric Blake <address@hidden>