[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address |
|
Date: |
Fri, 13 Nov 2015 15:08:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 13/11/2015 11:23, Stefan Hajnoczi wrote:
>> > tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr);
>> > - trace_memory_region_ops_read(mr, addr, tmp, size);
>> > + trace_memory_region_ops_read(mr->name, addr, tmp, size);
> mr->name may be NULL. There is a memory_region_name() function that
> always produces a real string. Perhaps it's best to use it.
It's also useful to have mr in the trace, for use within a debugger.
Paolo