Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

[Paolo Bonzini]

On 13/11/2015 22:25, Andreas Färber wrote:
> Thanks! sclp_init() seems to violate several QOM design principles in
> that it uses object_new() during TypeInfo::instance_init()

There's nothing wrong with that.  It's wrong however to use
qdev_set_parent_bus in instance_init.  That should be moved to
sclp_realize, before the realized property is set to true.

Otherwise, sclp->event_facility outlives its parent.  I'm not sure why
that works only with the list and not with the hash table though.  It
may well be a bug in this patch.

> and uses a TYPE_... constant as property name.

That's just a little weird, it doesn't break anything per se.

Paolo