[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/7] qmp: convert QMP code to use object prop
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/7] qmp: convert QMP code to use object property iterators |
|
Date: |
Tue, 17 Nov 2015 16:26:29 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange:
>> Stop directly accessing the Object "properties" field data
>> structure and instead use the formal object property iterator
>> APIs. This insulates the code from future data structure
>> changes in the Object struct.
>>
>> Signed-off-by: Daniel P. Berrange <address@hidden>
>> ---
>> qmp.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> Markus/Luiz, can you ack this change? Markus requested these iterators,
> I believe.
See my review of PATCH 1.