[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/7] qom: introduce ObjectPropertyIterator st
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 1/7] qom: introduce ObjectPropertyIterator struct for iteration |
|
Date: |
Tue, 17 Nov 2015 15:27:47 +0000 |
|
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Tue, Nov 17, 2015 at 04:25:22PM +0100, Markus Armbruster wrote:
> I apologize for the lateness of my review.
> > +void object_property_iter_free(ObjectPropertyIterator *iter)
> > +{
> > + if (!iter) {
> > + return;
> > + }
> > + g_free(iter);
>
> g_free(NULL) is perfectly safe; please drop the conditional.
The next patch in the series has to free some fields in 'iter'
so the check for NULL upfront is not redundant.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|