[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library tha
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds |
Date: |
Tue, 17 Nov 2015 17:25:26 +0000 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Fri, Nov 13, 2015 at 02:01:12PM +0100, Gerd Hoffmann wrote:
> On Fr, 2015-11-13 at 11:31 +0000, Daniel P. Berrange wrote:
> > Developers on 64-bit machines will often try to perform a
> > 32-bit build of QEMU by running
> >
> > ./configure --extra-cflags="-m32"
> >
> > Unfortunately if PKG_CONFIG_LIBDIR is not set to point to
> > the location of the 32-bit pkg-config files, then configure
> > will silently pick up the 64-bit pkg-config files and still
> > succeed.
>
> While being at it: I think it would be a good idea to record
> PKG_CONFIG_LIBDIR in config.status, otherwise it'll be lost the next
> time configure is touched and make figures it needs to re-run configure.
In the spirit of doing one logical change per patch, I'm sending a
separate patch to cover this suggestion.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|