[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot h
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper |
Date: |
Wed, 18 Nov 2015 12:02:50 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Denis V. Lunev" <address@hidden> wrote:
> to switch to snapshot on all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Greg Kurz <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> CC: Juan Quintela <address@hidden>
> CC: Kevin Wolf <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
suggestion:
un-export bdrv_snapshot_goto()?
I haven't looked if it is used anywhere else, but looks like one idea.
> ---
> block/snapshot.c | 20 ++++++++++++++++++++
> include/block/snapshot.h | 1 +
> migration/savevm.c | 15 +++++----------
> 3 files changed, 26 insertions(+), 10 deletions(-)
>
> diff --git a/block/snapshot.c b/block/snapshot.c
> index 61a6ad1..9f07a63 100644
> --- a/block/snapshot.c
> +++ b/block/snapshot.c
> @@ -403,3 +403,23 @@ int bdrv_all_delete_snapshot(const char *name,
> BlockDriverState **first_bad_bs,
> *first_bad_bs = bs;
> return ret;
> }
> +
> +
> +int bdrv_all_goto_snapshot(const char *name, BlockDriverState **first_bad_bs)
> +{
> + int err = 0;
> + BlockDriverState *bs = NULL;
> +
> + while (err == 0 && (bs = bdrv_next(bs))) {
> + AioContext *ctx = bdrv_get_aio_context(bs);
> +
> + aio_context_acquire(ctx);
> + if (bdrv_can_snapshot(bs)) {
> + err = bdrv_snapshot_goto(bs, name);
> + }
> + aio_context_release(ctx);
> + }
> +
> + *first_bad_bs = bs;
> + return err;
> +}
> diff --git a/include/block/snapshot.h b/include/block/snapshot.h
> index d02d2b1..0a176c7 100644
> --- a/include/block/snapshot.h
> +++ b/include/block/snapshot.h
> @@ -84,5 +84,6 @@ int bdrv_snapshot_load_tmp_by_id_or_name(BlockDriverState
> *bs,
> bool bdrv_all_can_snapshot(BlockDriverState **first_bad_bs);
> int bdrv_all_delete_snapshot(const char *name, BlockDriverState
> **first_bsd_bs,
> Error **err);
> +int bdrv_all_goto_snapshot(const char *name, BlockDriverState
> **first_bsd_bs);
>
> #endif
> diff --git a/migration/savevm.c b/migration/savevm.c
> index c52cbbe..254e51d 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2093,16 +2093,11 @@ int load_vmstate(const char *name)
> /* Flush all IO requests so they don't interfere with the new state. */
> bdrv_drain_all();
>
> - bs = NULL;
> - while ((bs = bdrv_next(bs))) {
> - if (bdrv_can_snapshot(bs)) {
> - ret = bdrv_snapshot_goto(bs, name);
> - if (ret < 0) {
> - error_report("Error %d while activating snapshot '%s' on
> '%s'",
> - ret, name, bdrv_get_device_name(bs));
> - return ret;
> - }
> - }
> + ret = bdrv_all_goto_snapshot(name, &bs);
> + if (ret < 0) {
> + error_report("Error %d while activating snapshot '%s' on '%s'",
> + ret, name, bdrv_get_device_name(bs));
> + return ret;
> }
>
> /* restore the VM state */
- [Qemu-devel] [PATCH for 2.9 v8 0/10] dataplane snapshot fixes, Denis V. Lunev, 2015/11/17
- [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/17
- [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Denis V. Lunev, 2015/11/17
- [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/17
- Re: [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper,
Juan Quintela <=
- [Qemu-devel] [PATCH 03/11] snapshot: create bdrv_all_delete_snapshot helper, Denis V. Lunev, 2015/11/17
- [Qemu-devel] [PATCH 05/11] migration: factor our snapshottability check in load_vmstate, Denis V. Lunev, 2015/11/17
- [Qemu-devel] [PATCH 07/11] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/17
- [Qemu-devel] [PATCH 06/11] snapshot: create bdrv_all_find_snapshot helper, Denis V. Lunev, 2015/11/17