qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: preserve various environment variabl


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] configure: preserve various environment variables in config.status
Date: Wed, 18 Nov 2015 08:40:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/18/2015 03:03 AM, Daniel P. Berrange wrote:

>>
>> Autoconf preserves CC, CFLAGS, LDFLAGS, LIBS, CPPFLAGS, and CPP by
>> default.  Also, PKG_CONFIG is typically preserved.  If you run libvirt's
>> './configure --help', you'll also notice a bunch of *_CFLAGS and *_LIBS
>> in the precious list starting under the label "Some influential
>> environment variables".
> 
> I'll add in env vars for all the commands like CC, CPP, MAKE, etc that
> QEMU's configure uses.  I've tried preserving various *FLAGS vars but
> the problem here is that configure will modify/augment those variables
> while it is running, so when we get to preserve the original flags we
> only have the munged version. In any case recommendation is to use
> --extra-cflags rather than CFLAGS, so I figure its not a big deal to
> skip preserving CFLAGS/LDFLAGS

Just one more case where we (perhaps needlessly) diverge from autotools
and make distro's life harder.  Oh well, it's not your fault that we
aren't using CFLAGS like other projects, and not preserving CFLAGS does
not change that.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]