Re: [Qemu-devel] [PATCH v12 36/36] qapi: Shorter visits of optional fields

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> For less code, reflect the determined boolean value of an optional
> visit back to the caller instead of making the caller read the
> boolean after the fact.
>
> The resulting generated code has the following diff:
>
> |-    visit_optional(v, &has_fdset_id, "fdset-id");
> |-    if (has_fdset_id) {
> |+    if (visit_optional(v, &has_fdset_id, "fdset-id")) {
> |         visit_type_int(v, &fdset_id, "fdset-id", &err);
> |         if (err) {
> |             goto out;
> |         }
> |     }
>
> Signed-off-by: Eric Blake <address@hidden>

Feels like a wash to me, but I'm willing to take it anyway, in
recognition of the massive amount of work you've been doing in this area
:)