[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 08/12] spapr_pci: Fold spapr_phb_vfio_reset() into spa
From: |
David Gibson |
Subject: |
[Qemu-devel] [RFC 08/12] spapr_pci: Fold spapr_phb_vfio_reset() into spapr_pci code |
Date: |
Thu, 19 Nov 2015 15:29:24 +1100 |
Simplify the sPAPR PCI code by folding spapr_phb_vfio_reset() into
spapr_phb_reset().
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_pci.c | 13 ++++++++++++-
hw/ppc/spapr_pci_vfio.c | 16 ----------------
2 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index d4cae05..915f51d 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1523,13 +1523,24 @@ static int spapr_phb_children_reset(Object *child, void
*opaque)
return 0;
}
+static void spapr_phb_eeh_reenable(sPAPRPHBState *sphb)
+{
+ vfio_eeh_as_op(&sphb->iommu_as, VFIO_EEH_PE_ENABLE);
+}
+
static void spapr_phb_reset(DeviceState *qdev)
{
/* Reset the IOMMU state */
object_child_foreach(OBJECT(qdev), spapr_phb_children_reset, NULL);
if (spapr_phb_eeh_available(SPAPR_PCI_HOST_BRIDGE(qdev))) {
- spapr_phb_vfio_reset(qdev);
+ /*
+ * The PE might be in frozen state. To reenable the EEH
+ * functionality on it will clean the frozen state, which
+ * ensures that the contained PCI devices will work properly
+ * after reboot.
+ */
+ spapr_phb_eeh_reenable(SPAPR_PCI_HOST_BRIDGE(qdev));
}
}
diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index 9aacf4b..aca9c46 100644
--- a/hw/ppc/spapr_pci_vfio.c
+++ b/hw/ppc/spapr_pci_vfio.c
@@ -72,22 +72,6 @@ static void spapr_phb_vfio_finish_realize(sPAPRPHBState
*sphb, Error **errp)
spapr_tce_get_iommu(tcet));
}
-static void spapr_phb_vfio_eeh_reenable(sPAPRPHBState *sphb)
-{
- vfio_eeh_as_op(&sphb->iommu_as, VFIO_EEH_PE_ENABLE);
-}
-
-void spapr_phb_vfio_reset(DeviceState *qdev)
-{
- /*
- * The PE might be in frozen state. To reenable the EEH
- * functionality on it will clean the frozen state, which
- * ensures that the contained PCI devices will work properly
- * after reboot.
- */
- spapr_phb_vfio_eeh_reenable(SPAPR_PCI_HOST_BRIDGE(qdev));
-}
-
static void spapr_phb_vfio_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
--
2.5.0
- [Qemu-devel] [RFC 00/12] Merge EEH support into spapr-pci-host-bridge, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 04/12] spapr_pci: Fold spapr_phb_vfio_eeh_configure() into spapr_pci code, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 01/12] vfio: Start improving VFIO/EEH interface, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 07/12] spapr_pci: Fold spapr_phb_vfio_eeh_set_option() into spapr_pci code, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 08/12] spapr_pci: Fold spapr_phb_vfio_reset() into spapr_pci code,
David Gibson <=
- [Qemu-devel] [RFC 10/12] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 05/12] spapr_pci: Fold spapr_phb_vfio_eeh_reset() into spapr_pci code, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 02/12] spapr_pci: Switch to vfio_eeh_as_op() interface, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 11/12] spapr_pci: Remove finish_realize hook, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 03/12] spapr_pci: Eliminate class callbacks, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 06/12] spapr_pci: Fold spapr_phb_vfio_eeh_get_state() into spapr_pci code, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 09/12] spapr_pci: Allow EEH on spapr-pci-host-bridge, David Gibson, 2015/11/18
- [Qemu-devel] [RFC 12/12] vfio: Eliminate vfio_container_ioctl(), David Gibson, 2015/11/18