Re: [Qemu-devel] [PATCH] fixup? qapi: Simplify QObject

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Eric Blake <address@hidden> writes:
[...]
>> diff --git a/qobject/qobject.c b/qobject/qobject.c
>> new file mode 100644
>> index 0000000..db86571
>> --- /dev/null
>> +++ b/qobject/qobject.c
>> @@ -0,0 +1,26 @@
>> +/*
>> + * QObject
>> + *
>> + * Copyright (C) 2015 Red Hat, Inc.
>> + *
>> + * This work is licensed under the terms of the GNU LGPL, version 2.1
>> + * or later.  See the COPYING.LIB file in the top-level directory.
>> + */
>> +
>> +#include "qemu-common.h"
>> +#include "qapi/qmp/qbool.h"
>> +#include "qapi/qmp/qdict.h"
>> +#include "qapi/qmp/qfloat.h"
>> +#include "qapi/qmp/qint.h"
>> +#include "qapi/qmp/qlist.h"
>> +#include "qapi/qmp/qstring.h"
>> +
>> +QDestroy qdestroy[QTYPE_MAX] = {
>> +    [QTYPE_QBOOL] = qbool_destroy_obj,
>> +    [QTYPE_QDICT] = qdict_destroy_obj,
>> +    [QTYPE_QFLOAT] = qfloat_destroy_obj,
>> +    [QTYPE_QINT] = qint_destroy_obj,
>> +    [QTYPE_QLIST] = qlist_destroy_obj,
>> +    [QTYPE_QSTRING] = qstring_destroy_obj,
>> +    /* [QTYPE_QNULL] = NULL, */
>> +};
>
> Suggest
>
>    QDestroy qdestroy[QTYPE_MAX] = {
>        [QTYPE_QNULL] = NULL,       /* no such object exists */

QTYPE_NONE, of course.

>        [QTYPE_QNULL] = NULL,       /* qnull_ is indestructible */
>        ...
>    };

[...]