[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tri
From: |
Bandan Das |
Subject: |
Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu |
Date: |
Thu, 19 Nov 2015 15:38:03 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> From: Bandan Das <address@hidden>
>
> There's no indication of any sort that i440fx doesn't support
> "iommu=on"
Oh, Markus quite didn't like this approach because this is
true for all other machines too. Anyway, I will keep in
mind to take care of this when I post a generic patch.
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Bandan Das <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Bandan Das <address@hidden>
> ---
> hw/pci-host/piix.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 7b2fbf9..715208b 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -34,6 +34,7 @@
> #include "sysemu/sysemu.h"
> #include "hw/i386/ioapic.h"
> #include "qapi/visitor.h"
> +#include "qemu/error-report.h"
>
> /*
> * I440FX chipset data sheet.
> @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev,
> Error **errp)
> static void i440fx_realize(PCIDevice *dev, Error **errp)
> {
> dev->config[I440FX_SMRAM] = 0x02;
> +
> + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
> + error_report("warning: i440fx doesn't support emulated iommu");
> + }
> }
>
> PCIBus *i440fx_init(const char *host_type, const char *pci_type,
- [Qemu-devel] [PULL 00/15] vhost, pc: fixes for 2.5, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 01/15] vhost: let SET_VRING_ENABLE message depends on protocol feature, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 02/15] vhost: don't send RESET_OWNER at stop, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 03/15] vhost-user: update spec description, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 04/15] vhost-user-test: support VHOST_USER_SET_VRING_ENABLE, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 06/15] vhost-user: start/stop all rings, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 05/15] vhost-user: print original request on error, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 09/15] tests/vhost-user-bridge: implement logging of dirty pages, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 11/15] vhost-user: ignore qemu-only features, Michael S. Tsirkin, 2015/11/19