[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tri
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu |
|
Date: |
Thu, 19 Nov 2015 22:00:38 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote:
>> "Michael S. Tsirkin" <address@hidden> writes:
>>
>> > From: Bandan Das <address@hidden>
>> >
>> > There's no indication of any sort that i440fx doesn't support
>> > "iommu=on"
>>
>> Oh, Markus quite didn't like this approach because this is
>> true for all other machines too. Anyway, I will keep in
>> mind to take care of this when I post a generic patch.
>
> Do you think I should revert this one then?
The patch isn't wrong, it merely addresses only one special case of a
generic issue. Probably the most important case in practice. If I
understood Bandan correctly, he intended to drop this patch and work on
a general solution. As far as I'm concerned, you can keep this patch if
dropping it is inconvenient.
- [Qemu-devel] [PULL 03/15] vhost-user: update spec description, (continued)
- [Qemu-devel] [PULL 03/15] vhost-user: update spec description, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 04/15] vhost-user-test: support VHOST_USER_SET_VRING_ENABLE, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 06/15] vhost-user: start/stop all rings, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 05/15] vhost-user: print original request on error, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 09/15] tests/vhost-user-bridge: implement logging of dirty pages, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 11/15] vhost-user: ignore qemu-only features, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 10/15] specs/vhost-user: fix spec to match reality, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 12/15] vhost-user: fix log size, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 13/15] acpi: fix buffer overrun on migration, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 14/15] tests: re-enable vhost-user-test, Michael S. Tsirkin, 2015/11/19
[Qemu-devel] [PULL 15/15] exec: silence hugetlbfs warning under qtest, Michael S. Tsirkin, 2015/11/19