Re: [Qemu-devel] [PATCH 1/3] vmw_pvscsi: Set device subsystem and revision

[Dmitry Fleytman]

Acked-by: Dmitry Fleytman <address@hidden>

> On 19 Nov 2015, at 16:21 PM, Shmulik Ladkani <address@hidden> wrote:
> 
> To be VMware PVSCSI SCSI Controller, rev 02.
> As reported by the VMware virtual hardware.
> 
> Signed-off-by: Shmulik Ladkani <address@hidden>
> ---
> hw/scsi/vmw_pvscsi.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 9c71f31..df4d383 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -1069,10 +1069,6 @@ pvscsi_init(PCIDevice *pci_dev)
> 
>     trace_pvscsi_state("init");
> 
> -    /* PCI subsystem ID */
> -    pci_dev->config[PCI_SUBSYSTEM_ID] = 0x00;
> -    pci_dev->config[PCI_SUBSYSTEM_ID + 1] = 0x10;
> -
>     /* PCI latency timer = 255 */
>     pci_dev->config[PCI_LATENCY_TIMER] = 0xff;
> 
> @@ -1190,7 +1186,9 @@ static void pvscsi_class_init(ObjectClass *klass, void 
> *data)
>     k->vendor_id = PCI_VENDOR_ID_VMWARE;
>     k->device_id = PCI_DEVICE_ID_VMWARE_PVSCSI;
>     k->class_id = PCI_CLASS_STORAGE_SCSI;
> -    k->subsystem_id = 0x1000;
> +    k->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE;
> +    k->subsystem_id = PCI_DEVICE_ID_VMWARE_PVSCSI;
> +    k->revision = 0x2;
>     dc->reset = pvscsi_reset;
>     dc->vmsd = &vmstate_pvscsi;
>     dc->props = pvscsi_properties;
> -- 
> 1.9.1
>