Re: [Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup

[Paolo Bonzini]

On 23/11/2015 13:39, Kevin Wolf wrote:
> One test case closed an event notifier (event_notifier_cleanup())
> without first disabling it (set_event_notifier(..., NULL)). This
> resulted in a leftover handle 0 that was added to each subsequent
> WaitForMultipleObjects() call, causing the function to fail (invalid
> handle).
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/test-aio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/test-aio.c b/tests/test-aio.c
> index 1623803..e188d8c 100644
> --- a/tests/test-aio.c
> +++ b/tests/test-aio.c
> @@ -393,6 +393,7 @@ static void test_aio_external_client(void)
>              aio_enable_external(ctx);
>          }
>          assert(aio_poll(ctx, false));
> +        set_event_notifier(ctx, &data.e, NULL);
>          event_notifier_cleanup(&data.e);
>      }
>  }
> 

Reviewed-by: Paolo Bonzini <address@hidden>