Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size

[Eric Blake]

On 11/23/2015 07:27 AM, Paolo Bonzini wrote:
> 
> 
> On 20/11/2015 18:32, Eric Blake wrote:
>>> static void qlist_size_iter(QObject *obj, void *opaque)
>>> {
>>>     size_t *count = opaque;
>>>     (*count)++;
>>> }
>>
>> Yuck - we don't track size independently?  Seems like it might make a
>> worthwhile addition,
> 
> Would you change your mind, if I told you that qlist_size is unused? :)

Deleting dead code is a perfectly acceptable alternative to advertising
what should normally be an O(1) operation with an O(n) implementation. :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature