[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage |
|
Date: |
Mon, 23 Nov 2015 17:31:33 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Wen Congyang <address@hidden> wrote:
> If we set migration speed in a very large value, block-migration will try to
> read
> all data to the memory. Because
> (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE
> will be overflow, and it will be always less than rate limit.
>
> There is no need to read too many data into memory when the rate limit is
> very large.
> So limit the memory usage can fix the overflow problem.
>
> Signed-off-by: Wen Congyang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
If no block layer maintainer objects, I will apply this to my tree.
Later, Juan.